Improve docs on secondary root rotation #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in #115
cajun-rat
force-pushed
the
docs/secondary-root-rotation
branch
from
279b298
to
e29c737
Compare
pattivacek
approved these changes
Sep 11, 2024
Comment on lines
+30
to
+31
| * Note that this _required_ for correct initialization. The API here is | ||
| * particularly error prone and should be improved: |
There was a problem hiding this comment.
There's is a verb missing in the first sentence, but otherwise, thanks, this is great and really makes the point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #115