fix(otelgorm): added optional db key to skip tracing #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDeKeyzer
changed the title
WilliamDeKeyzer
changed the title
survivorbat
reviewed
Feb 29, 2024
added 5 commits
February 29, 2024 09:20
…Keyzer/opentelemetry-go-extra into feature/no-trace-option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there are database operations ongoing that are continuously ongoing and are completely irrelevant for tracing UIs. You just don't want useless traces to be present in this case, as it generates a lot of noise.
With the custom key (which is exported from this lib) you can now set it in the relevant parts of your own codebase.
db.Set(otelgorm.EnabledTraceDatabaseKey, false)This will make sure the next queries towards this db object will not start new traces.
Do not forget to un-set this db key is other clals happen on this db object and you do want to trace those.
db.Set(otelgorm.EnabledTraceDatabaseKey, true)