Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Mejoras al CI y al README #113

Merged
merged 22 commits into from
Nov 7, 2023
Merged

[EPIC] Mejoras al CI y al README #113

merged 22 commits into from
Nov 7, 2023

Conversation

fdodino
Copy link
Contributor

@fdodino fdodino commented Nov 4, 2023

Proyecto

README

  • agregar badges de cobertura, de build del CI, de la licencia
  • mejorar doc para explicar la instalación a los usuarios
  • explicar cómo se usa como dev
    • link a good first issues
    • link a discord como Wollok LSP
    • link a Wollok Language
  • explicar qué skills se necesitan para contribuir (wiki)
  • armar un gif para contar cómo se usa

@fdodino fdodino marked this pull request as draft November 4, 2023 04:36
@fdodino fdodino changed the title Update ci [EPIC] Mejoras al CI y al README Nov 4, 2023
Copy link

codecov bot commented Nov 4, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@fdodino
Copy link
Contributor Author

fdodino commented Nov 5, 2023

@PalumboN @ivojawer les pido si se pueden bajar la versión y chequear que les funcione el diagrama dinámico. Una cosa que le pasó a @Juancete y ahora a mí también es que los paths tenían que incluir src (fíjense en el package.json y también ahora en la función publicPath que se necesita para generar el path del diagrama, sospecho que también va a pasar con el de game).

@fdodino fdodino requested review from ivojawer and PalumboN November 5, 2023 03:18
@fdodino fdodino marked this pull request as ready for review November 5, 2023 03:18
Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re piola @fdodino !

Dejé un pequeño suggest. A la noche me bajo la branch y la pruebo para estar seguros que los paths andan :)

Si todo está ok le mando merge 🚀

src/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: Nahuel Palumbo <[email protected]>
@PalumboN PalumboN merged commit 970d439 into master Nov 7, 2023
3 checks passed
@PalumboN PalumboN deleted the update-ci branch November 7, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants