-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/logger #120 #125
Feature/logger #120 #125
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 84.68% 85.63% +0.94%
==========================================
Files 7 9 +2
Lines 653 696 +43
Branches 158 161 +3
==========================================
+ Hits 553 596 +43
Misses 100 100 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chetisimo! 📝🚀
test/time-measurer.test.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wooo no la tenia a esta magia de sinon 🔥 🔥
Co-authored-by: ivojawer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qué groso Fer! Impecable laburo 👏 🚀 🤖
Dejé un pequeño comentario sobre qué cosas serían interesantes loguear respecto al uso del REPL. Quizá convenga levantar un issue y verlo después de hacer algunas pruebas.
Qué se incorpora
En este PR incorporamos el logger por archivo para loguear
No logueamos
De paso, saniticé el stack trace que mostramos:
Derived from TypeScript stack
porque forma parte del message y no del stack. Se la saqué.Implementación
loglevel
dado que usa chalk con caracteres especiales para mostrar colores, bold, italic, etc. en la terminal y eso se ve feucho en un archivostrip-ansi
como biblioteca pero rompía el proyecto y la verdad es que el log por consola y el de archivo son bastante diferentes (en cuanto a verbosidad y a lo que muestran), así que tenemos dos por separadoMuestra de cómo se loguea
Un test:
Un programa: