Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prueba: mover flushEvents al frontend #140

Closed

Conversation

mind-ar
Copy link
Contributor

@mind-ar mind-ar commented Mar 22, 2024

este pr es una prueba de concepto para el issue #139

@mind-ar mind-ar marked this pull request as draft March 22, 2024 23:27
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 83.92%. Comparing base (9060120) to head (a5069f3).

Files Patch % Lines
src/commands/run.ts 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   84.05%   83.92%   -0.13%     
==========================================
  Files           9        9              
  Lines         671      672       +1     
  Branches      154      155       +1     
==========================================
  Hits          564      564              
- Misses        107      108       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PalumboN
Copy link
Contributor

La idea de que el cliente web le pida al server los flushEvents agrega más overhead y todo se vuelve más lento.

Cerramos este PR ya que era un experimento para saber qué onda eso. Cualquier cosa se puede recuperar el laburo.

@PalumboN PalumboN closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants