Fix windows tests #142
Merged
Fix windows tests #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 84.05% 84.05%
=======================================
Files 9 9
Lines 671 671
Branches 154 154
=======================================
Hits 564 564
Misses 107 107 ☔ View full report in Codecov by Sentry. |
ivojawer
approved these changes
Mar 26, 2024
PalumboN
approved these changes
Mar 28, 2024
Entiendo que game siempre funcionó con VSCode lo maneja siempre con |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probando el PR de Ivo corrí los tests y me saltó este error:
Esto es porque hay un proyecto de ejemplo que tiene el path de la imagen apuntando a
smalls/1.pngy para adaptarlo a Windows tendríamos que generarlo en base al sistema operativo. Con el update simplemente asumo que usamos la barra porque el proyecto está en Linux/Mac y ya. Con lo que da que pensar, no? si dos personas laburan en un proyecto de game en distintos sistemas operativos (uno Windows) cómo se hace.