Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #149 : REPL sitio web #176

Merged
merged 10 commits into from
Sep 17, 2024
Merged

Fix #149 : REPL sitio web #176

merged 10 commits into from
Sep 17, 2024

Conversation

fdodino
Copy link
Contributor

@fdodino fdodino commented Aug 17, 2024 •
edited
Loading

Pre-requisitos

Necesitamos primero cerrar este PR de wollok-ts para releasear éste.

  • Consola refactorizada y testeada
  • Diagrama dinámico refactorizado
  • Testeo del diagrama dinámico

@fdodino fdodino marked this pull request as draft August 17, 2024 14:01
@fdodino fdodino marked this pull request as ready for review August 25, 2024 16:37
@fdodino fdodino requested review from PalumboN and ivojawer August 25, 2024 16:37
PalumboN
PalumboN approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Al re toke roqueeeee 🐶 🌐 💻

test/repl.test.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estos tests no se movieron a TS?

Acá solamente se debería testear successDescription y failureDescription no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claro, yo estoy testeando más integración acá: el resultado es casi el mismo que el test de wollok-ts pero formateando con la cruz y el check...

test/diagram.test.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idealmente estos tests se deberían movel a tools (o a TS, no me queda claro cómo quedaron las responsabilidades).

Si es a tools, todavía no tenemos tests allá. Estaría bueno agregarlos pero podemos cargar un issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coincido en que debería moverse a tools el adapter que convierte de la interfaz a cytoscape. Próximamente lo podemos encarar.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahora que veo todo, para mí debería moverse a tool el algoritmo que crea el grafo a partir de la evaluation también

@PalumboN PalumboN merged commit 97e3e34 into master Sep 17, 2024
1 check passed
@PalumboN PalumboN deleted the fix-#149-web-repl branch September 17, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PalumboN PalumboN PalumboN approved these changes

@ivojawer ivojawer Awaiting requested review from ivojawer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdodino @PalumboN