Fix #292 Error poco claro cuando se omite el receptor de un mensaje #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivojawer
approved these changes
Oct 27, 2024
PalumboN
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Hay que revisar esos TODOs y mepa que estamos 🚀
QUE LINDO ver un PR de @npasserini 🤩
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 89.76% 89.78% +0.01%
==========================================
Files 28 28
Lines 3184 3190 +6
Branches 581 581
==========================================
+ Hits 2858 2864 +6
Misses 171 171
Partials 155 155 ☔ View full report in Codecov by Sentry. |
…luyendo los parámetros.
npasserini
force-pushed
the
292-error-poco-claro-cuando-se-omite-el-receptor-de-un-mensaje
branch
from
1ed91d4 to
d5f18ff
Compare
PalumboN
approved these changes
Jan 2, 2025
Comment on lines
+2741
to
+2743
| it('should recover from malformed message send without arguments', () => { | ||
| `m()`.should.be.parsedBy(parser) | ||
| .recoveringFrom(parse.MALFORMED_MESSAGE_SEND, 0, 1) |
There was a problem hiding this comment.
Y qué onda con una chain onda m1().m2()? Entiendo que era el caso del TODO anterior, no?
PalumboN
deleted the
292-error-poco-claro-cuando-se-omite-el-receptor-de-un-mensaje
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.