Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded views - Basic wiring with simple views #210

Merged
merged 23 commits into from
Sep 3, 2024
Merged

Embedded views - Basic wiring with simple views #210

merged 23 commits into from
Sep 3, 2024

Conversation

crow
Copy link
Contributor

@crow crow commented Jul 25, 2024 •
edited
Loading

What do these changes do?

Add basic initial support for embedded views.

Why are these changes necessary?

To support embedded views in flutter.

How did you verify these changes?

Manual testing.

Verification Screenshots:

iOS:
https://github.com/user-attachments/assets/eff35227-a7ed-47a1-b270-b33aa5e31a68

Android:
https://github.com/user-attachments/assets/f9611935-bd9d-4306-a436-79b058d7a67f

@crow crow requested a review from a team as a code owner July 25, 2024 00:38
@crow crow changed the base branch from main to release-7.7.0 August 7, 2024 23:36
Base automatically changed from release-7.7.0 to main August 13, 2024 12:57
@rlepinski
Copy link
Collaborator

Android needs the same multicasting changes you made on iOS

@crow crow merged commit f77ba24 into main Sep 3, 2024
3 checks passed
@crow crow deleted the MOBILE-4620 branch September 3, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlepinski rlepinski rlepinski approved these changes

@jyaganeh jyaganeh jyaganeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crow @rlepinski @jyaganeh