Add comment for env

urfave · Nov 21, 2024 · dcdab00 · dcdab00
1 parent 2d02868
commit dcdab00
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/godoc-current.txt b/godoc-current.txt
@@ -595,6 +595,7 @@ type EnvValueSource interface {
 	IsFromEnv() bool
 	Key() string
 }
+    EnvValueSource is to specifically detect env sources when printing help text
 
 type ErrorFormatter interface {
 	Format(s fmt.State, verb rune)

diff --git a/testdata/godoc-v3.x.txt b/testdata/godoc-v3.x.txt
@@ -595,6 +595,7 @@ type EnvValueSource interface {
 	IsFromEnv() bool
 	Key() string
 }
+    EnvValueSource is to specifically detect env sources when printing help text
 
 type ErrorFormatter interface {
 	Format(s fmt.State, verb rune)

diff --git a/value_source.go b/value_source.go
@@ -17,6 +17,8 @@ type ValueSource interface {
 	Lookup() (string, bool)
 }
 
+// EnvValueSource is to specifically detect env sources when
+// printing help text
 type EnvValueSource interface {
 	IsFromEnv() bool
 	Key() string
@@ -43,7 +45,7 @@ func (vsc *ValueSourceChain) EnvKeys() []string {
 	vals := []string{}
 
 	for _, src := range vsc.Chain {
-		if v, ok := src.(EnvValueSource); ok {
+		if v, ok := src.(EnvValueSource); ok && v.IsFromEnv() {
 			vals = append(vals, v.Key())
 		}
 	}