-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Махалин Николай #6
base: master
Are you sure you want to change the base?
Conversation
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Пройдено тестов 14 из 19 |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍏 Пройдено тестов 19 из 19 |
@Victoria-Vladimirova обрати внимание решено доп. задание |
Николай, отправь PR ещё раз |
🍏 Пройдено тестов 19 из 19 |
@FrodoTheTrue обрати внимание решено доп. задание |
почему билд сломан? |
} | ||
|
||
function convertTime(time, timezone) { | ||
time = /(\d{2}):(\d{2})\+(\d+)/.exec(time); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DRY
function convertSchedule(schedule, timezone) { | ||
var newSchedule = []; | ||
for (var name in schedule) { | ||
if (schedule.hasOwnProperty(name)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
зачем эта проверка?
var newSchedule = []; | ||
for (var name in schedule) { | ||
if (schedule.hasOwnProperty(name)) { | ||
var persSchedule = schedule[name] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
persSchedule не очень понятное название
function getRobberyTimes(fullSchedule, duration) { | ||
var robberyTimes = []; | ||
var iter = []; | ||
var iterMax = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
хитро сделано с хранением числа в массиве :)
iter, iterMax здесь не подходят, не понятно что итерируем и как
getIters(iter, iterMax, fullSchedule); | ||
|
||
while (iter[0] < iterMax[0]) { | ||
var minMax = getMinMax(fullSchedule, iter); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
странное название для функции
* @returns {Object} | ||
*/ | ||
exports.getAppropriateMoment = function (schedule, duration, workingHours) { | ||
console.info(schedule, duration, workingHours); | ||
exports.getAppropriateMoment = function sad(schedule, duration, workingHours) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sad ? 😢 😞 😿
🍅 |
No description provided.