-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Бабушкина Анастасия #10
base: master
Are you sure you want to change the base?
Conversation
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍏 Пройден линтинг и базовые тесты |
🍏 |
<input checked name="page" type="radio" class="page1"> | ||
<input name="page" type="radio" class="page2"> | ||
<input name="page" type="radio" class="page3"> | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main
<input name="page" type="radio" class="page2"> | ||
<input name="page" type="radio" class="page3"> | ||
<div> | ||
<img class="grandmother" src="картинки/бабушка.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не хватает title и размеров
<div> | ||
<img class="grandmother" src="картинки/бабушка.png" | ||
alt="Бабушка Галя"> | ||
<div class="fstpage"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Непонятное сокращение в названии
<div class="harvest"> | ||
<img class="image" tabindex="0" src="картинки/капуста.jpg" | ||
alt="большая капуста"> | ||
<span class="description"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему именно span
, а не p
?
{ | ||
right: 20px; | ||
position: fixed; | ||
height: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
height: auto;
точно нужно здесь?
|
||
.image | ||
{ | ||
height: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тот же вопрос про height: auto;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вот у картинки height: auto; нужен потому что картинки не квадратные, без него они сильно растягиваются
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Потому что нужно одно из двух, либо атрибуты, либо размеры в CSS
🍅 |
По поводу firefox, не поняла, у меня открывается |
🍏 Пройден линтинг и базовые тесты |
🍏 исправила замечания. Теперь картинка не прыгает, а увеличивается |
Выглядит хорошо ) Будет еще круто, если картинка не будет исчезать с заднего фона при клике на нее |
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍅
body | ||
{ | ||
width: 100%; | ||
height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем нужна 100% высота?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Позиция у страниц у меня фиксированная, прокрутку я убрала, и для того что бы при наведении на картинку описание отображалось полностью, а не частично, я задаю 100% высоту
height: 100%; | ||
font-family: 'Helvetica Neue', Helvetica, sans-serif; | ||
margin: 20px; | ||
overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выглядит как пляска под решение, а если эта галерея будет компонентом на странице, то что?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не совсем понимаю что не так, margin?
|
||
.image | ||
{ | ||
height: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Потому что нужно одно из двух, либо атрибуты, либо размеры в CSS
input[type='radio'].page3:checked ~ main .firstPage, | ||
input[type='radio'].page3:checked ~ main .secondPage | ||
{ | ||
display: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не понятно почему это не объединено с предыдущими двумя
Посмотреть решение