-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Махаев Семён #36
base: master
Are you sure you want to change the base?
Махаев Семён #36
Conversation
🍅 Не пройден линтинг или базовые тесты |
🍏 Пройден линтинг и базовые тесты |
🍏 Пройден линтинг и базовые тесты |
🍏 Пройден линтинг и базовые тесты |
При изменении ширины экрана нет адаптивности, пользователи с узким экраном расстроятся |
При клике на фотографию:
У тебя квадрат, причем где-то слева внизу - очень неудобное место. Давай сделаем согласно макету |
<div class="card"> | ||
<div class="image-wrapper"> | ||
<label for="img-01" class="fullscreen-label"> | ||
<img title="Tomate" alt="Tomate" src="./img/01.png"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tomato
<div class="fullscreen-wrapper"> | ||
<img title="Aubergine" alt="Aubergine" src="./img/05.png"> | ||
<input id="close-img-05" class="close-input" type="radio" name="fullscreen-input-5"> | ||
<label for="close-img-05" class="close-label"></label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай сделаем один крестик для всех
|
||
.group-label-1:before | ||
{ | ||
content: '\e900'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
И не только тут
<link rel="stylesheet" type="text/css" href="index.css"> | ||
</head> | ||
<body> | ||
<h1 class="head">Бабуленькин урожай</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
давай назовем класс по-другому, а то совпадает с тегом
|
||
.group-label | ||
{ | ||
font-family: 'Kurale-Regular', serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это очень странно, по сути ты применяешь оформление к label, которые не являются текстом
И еще не поняла, зачем тебе картинки в формате |
А вообще мне понравились картинки, довольно забавно) |
🍅 |
Посмотреть решение