Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Дорохова Татьяна #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Дорохова Татьяна #50

wants to merge 1 commit into from

Conversation

DorokhovaTatiana
Copy link

@DorokhovaTatiana DorokhovaTatiana commented Nov 15, 2016

@honest-hrundel
Copy link

🍏 Пройден линтинг и базовые тесты

@chipolinka
Copy link

chipolinka commented Nov 17, 2016

Привет! Классно выглядит! 😉
Но вот пара замечаний по внешнему виду:

  • Переключатели не по центру (а хотелось бы)
  • Попап не "наплывает" на соседей при наведении. Вот так: screenshot from 2016-11-17 10-52-38
  • При уменьшении экрана происходит наезд:
    screenshot from 2016-11-17 11-40-18
  • Не хочешь ли сделать доп. задание?) Оно не очень сложное.
  • Анимации 👍

@@ -0,0 +1,119 @@
main

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все основные правила лучше применять к body

.vegetables-gallery
{
width: 3400px;
transition: all 2s ease-in-out;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поменяй порядок: сначала правила с префиксами, потом без них

z-index: 5;
width: 100%;
height: 100%;
display: none;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дублируется правило

@chipolinka
Copy link

🍅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants