Мартовицкая Вероника #109

Veronica2998 · 2018-10-25T12:26:53Z

No description provided.

honest-hrundel · 2018-10-25T12:27:15Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-25T12:38:45Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-25T12:42:06Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-25T16:28:14Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-25T16:32:37Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-25T16:36:53Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-25T16:44:44Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-25T17:04:00Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-27T17:21:50Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-28T13:27:48Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-28T13:31:59Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-28T13:38:51Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-28T13:42:10Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-29T11:56:46Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-10-29T12:04:44Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-11-05T07:52:07Z

🍏 Пройдено тестов 26 из 26

honest-hrundel · 2018-11-05T07:52:08Z

@FrodoTheTrue обрати внимание: решено доп. задание

honest-hrundel · 2018-11-05T18:05:20Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-11-05T18:09:06Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-11-05T18:13:00Z

🍅 Не пройден линтинг или базовые тесты

honest-hrundel · 2018-11-05T18:15:14Z

🍏 Пройдено тестов 26 из 26

honest-hrundel · 2018-11-05T18:15:15Z

@FrodoTheTrue обрати внимание: решено доп. задание

FrodoTheTrue · 2018-11-11T13:44:44Z

phone-book.js

@@ -30,16 +55,51 @@ function add(phone, name, email) {
 * @returns {Boolean}
 */
 function update(phone, name, email) {
+    if (phoneBook[phone] && isValidParams(phone, name, email)) {
+        if (!email || (email === '')) {


скобки лишние

FrodoTheTrue · 2018-11-11T13:44:55Z

phone-book.js

+        return 0;
+    }
+    let res;
+    var count = 0;


FrodoTheTrue · 2018-11-11T13:45:05Z

phone-book.js

+    }
+    let res;
+    var count = 0;
+    for (var phone of Object.keys(phoneBook)) {


FrodoTheTrue · 2018-11-11T13:45:16Z

phone-book.js

+        return [];
+    }
+    const result = [];
+    var res;


FrodoTheTrue · 2018-11-11T13:45:28Z

phone-book.js

+}
+
+function view(result) {
+    var recordSought = [];


FrodoTheTrue · 2018-11-11T13:47:11Z

phone-book.js

+        return 0;
+    }
+    const newCsv = csv.split('\n');
+    var count = 0;


FrodoTheTrue · 2018-11-11T13:48:15Z

phone-book.js

+function isValidParams(phone, name) {
+    var tel = /(^[0-9]{10}$)/;
+
+    return phone && (tel.test(phone)) && (name !== '') &&


скобки

name !== '' можно не проверять

honest-hrundel · 2018-11-11T15:38:39Z

🍏 Пройдено тестов 26 из 26

honest-hrundel · 2018-11-11T15:38:39Z

@FrodoTheTrue обрати внимание: решено доп. задание

FrodoTheTrue · 2018-11-17T09:34:57Z

phone-book.js

@@ -19,6 +33,17 @@ let phoneBook;
 * @returns {Boolean}
 */
 function add(phone, name, email) {
+    if (!(phone in phoneBook) && isValidParams(phone, name, email)) {
+        if (!email || email === '') {


'' == false

FrodoTheTrue · 2018-11-17T09:35:05Z

phone-book.js

+ * @returns {Boolean}
+ */
+function isValidParams(phone, name) {
+    var tel = /(^[0-9]{10}$)/;


FrodoTheTrue · 2018-11-17T09:35:17Z

phone-book.js

@@ -30,16 +55,51 @@ function add(phone, name, email) {
 * @returns {Boolean}
 */
 function update(phone, name, email) {
+    if (phoneBook[phone] && isValidParams(phone, name, email)) {
+        if (!email || email === '') {


'' == false

FrodoTheTrue · 2018-11-17T09:35:52Z

phone-book.js

+    if (query === '*') {
+        return record;
+    }
+    if (record[0].includes(query) === true || record[1].includes(query) === true ||


давай извлечем из record все сразу

FrodoTheTrue · 2018-11-17T09:36:08Z

phone-book.js

+            result.push(res);
+        }
+    }
+    var record;


FrodoTheTrue · 2018-11-17T09:36:17Z

phone-book.js

+    var record;
+    record = view(result);
+
+    return record.sort();


как сортируем?

FrodoTheTrue · 2018-11-17T09:36:35Z

phone-book.js

+    let count = 0;
+    for (let line of newCsv) {
+        let contact = line.split(';');
+        var phone = contact[1];


FrodoTheTrue · 2018-11-17T09:36:41Z

phone-book.js

+    for (let line of newCsv) {
+        let contact = line.split(';');
+        var phone = contact[1];
+        var name = contact[0];


FrodoTheTrue · 2018-11-17T09:36:46Z

phone-book.js

+        let contact = line.split(';');
+        var phone = contact[1];
+        var name = contact[0];
+        var email = contact[2];


пока не все

82479ad

пока не все

ed0b546

пока не все

cbfc634

доработочкиÐ

f09eb4c

доработочки

6723851

доработочки

90b7643

доработочки

7ac257b

доработочки

877fc76

что то не так

d174d3c

доошибочка

9e50221

hello

f014f2f

hello

17076db

hello

a0d467b

доработочки

b549743

доработочки

1049d54

забыла

845661b

забыла

eae35db

забыла

dca7ec7

забя запуталааась

37cdc90

FrodoTheTrue reviewed Nov 11, 2018

View reviewed changes

phone-book.js Outdated

return 0;

}

let res;

var count = 0;

Copy link

FrodoTheTrue Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let

FrodoTheTrue reviewed Nov 11, 2018

View reviewed changes

phone-book.js Outdated

}

let res;

var count = 0;

for (var phone of Object.keys(phoneBook)) {

Copy link

FrodoTheTrue Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

FrodoTheTrue reviewed Nov 11, 2018

View reviewed changes

phone-book.js Outdated

return [];

}

const result = [];

var res;

Copy link

FrodoTheTrue Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let

FrodoTheTrue reviewed Nov 11, 2018

View reviewed changes

phone-book.js Outdated

}

function view(result) {

var recordSought = [];

Copy link

FrodoTheTrue Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

FrodoTheTrue reviewed Nov 11, 2018

View reviewed changes

phone-book.js Outdated

return 0;

}

const newCsv = csv.split('\n');

var count = 0;

Copy link

FrodoTheTrue Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let

FrodoTheTrue reviewed Nov 11, 2018

View reviewed changes

task

8c543f3

FrodoTheTrue reviewed Nov 17, 2018

View reviewed changes

phone-book.js

* @returns {Boolean}

*/

function isValidParams(phone, name) {

var tel = /(^[0-9]{10}$)/;

Copy link

FrodoTheTrue Nov 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

FrodoTheTrue reviewed Nov 17, 2018

View reviewed changes

phone-book.js

result.push(res);

}

}

var record;

Copy link

FrodoTheTrue Nov 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

FrodoTheTrue reviewed Nov 17, 2018

View reviewed changes

phone-book.js

var record;

record = view(result);

return record.sort();

Copy link

FrodoTheTrue Nov 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

как сортируем?

FrodoTheTrue reviewed Nov 17, 2018

View reviewed changes

phone-book.js

let count = 0;

for (let line of newCsv) {

let contact = line.split(';');

var phone = contact[1];

Copy link

FrodoTheTrue Nov 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

FrodoTheTrue reviewed Nov 17, 2018

View reviewed changes

phone-book.js

for (let line of newCsv) {

let contact = line.split(';');

var phone = contact[1];

var name = contact[0];

Copy link

FrodoTheTrue Nov 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

FrodoTheTrue reviewed Nov 17, 2018

View reviewed changes

phone-book.js

let contact = line.split(';');

var phone = contact[1];

var name = contact[0];

var email = contact[2];

Copy link

FrodoTheTrue Nov 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

Мартовицкая Вероника #109

Are you sure you want to change the base?

Мартовицкая Вероника #109

Conversation

Veronica2998 commented Oct 25, 2018

honest-hrundel commented Oct 25, 2018

honest-hrundel commented Oct 25, 2018

honest-hrundel commented Oct 25, 2018

honest-hrundel commented Oct 25, 2018

honest-hrundel commented Oct 25, 2018

honest-hrundel commented Oct 25, 2018

honest-hrundel commented Oct 25, 2018

honest-hrundel commented Oct 25, 2018

honest-hrundel commented Oct 27, 2018

honest-hrundel commented Oct 28, 2018

honest-hrundel commented Oct 28, 2018

honest-hrundel commented Oct 28, 2018

honest-hrundel commented Oct 28, 2018

honest-hrundel commented Oct 29, 2018

honest-hrundel commented Oct 29, 2018

honest-hrundel commented Nov 5, 2018

honest-hrundel commented Nov 5, 2018

honest-hrundel commented Nov 5, 2018

honest-hrundel commented Nov 5, 2018

honest-hrundel commented Nov 5, 2018

honest-hrundel commented Nov 5, 2018

honest-hrundel commented Nov 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

honest-hrundel commented Nov 11, 2018

honest-hrundel commented Nov 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment