Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Шумейко Евгений #106

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Шумейко Евгений #106

wants to merge 4 commits into from

Conversation

EvgeniiShumeiko
Copy link

@EvgeniiShumeiko EvgeniiShumeiko commented Oct 23, 2018

@honest-hrundel honest-hrundel changed the title Евгений Шумейко Шумейко Евгений Oct 23, 2018
@honest-hrundel
Copy link

🍏 Пройден линтинг и базовые тесты

@honest-hrundel
Copy link

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link

🍏 Пройден линтинг и базовые тесты

@honest-hrundel
Copy link

🍏 Пройден линтинг и базовые тесты

Copy link

@SemyonMakhaev SemyonMakhaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍅

Привет! Классно получилось)

А как же вертикальный текст?
А цитаты? Для них нужно использовать семантичный тег.
Будет круто, если реализуешь настройку темы и параметров текста через элементы input

Старайся избегать селекторов по тегу. Селекторы класса позволят сделать твою вёрстку более контролируемой

border-bottom: 1px solid #000;
}

div.title

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тег в селекторе класса можно не указывать

{
width: 130px;
height: 90px;
text-align: center;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Правило дублируется, нужно вынести в отдельный класс или сгруппировать селекторы


.big-col
{
width: calc((100% / 3) * 2);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

При использовании CSS-свойств обращай внимание на поддержку браузерами. На правах рекламы могу порекомендовать ресурс https://caniuse.com

word-break: normal;
text-align: justify;
font-family: Arial, sans-serif;
font-size: 14px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно в одно правило font

{
font-family: Arial, sans-serif;
font-style: italic;
text-align: center;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Правила часто дублируются

</div>
<div class="main-title">
<img src="https://upload.wikimedia.org/wikipedia/commons/5/58/NewYorkTimes.svg"
title="The New York Times" alt="The New York Times">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

VOL. CLXVIII . . . No. 58,124
</span>
<span class="company">
© 2018 The New York Times Company

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&copy;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants