-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARPA Exporter - Add python business-logic for building zipfile and emailing user #3934
ARPA Exporter - Add python business-logic for building zipfile and emailing user #3934
Conversation
…the archive. update build_zip to match latest variable names
This change fetches the UploadInfo iterator (which streams from S3) first, and passes the iterator to `build_zip()`. This reduces call complexity and simplifies / isolates related tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya! This looks fine to me!
I do have one question, but it's not a review-blocker or anything. Where do the email_templates/base.html
(and other templates) come from? I know that writing HTML emails that render acceptably in a wide variety of email clients/webmail sites can be tricky. If it's from some other example project/code, could we drop a comment or readme somewhere noting that?
Thanks!
@sophaskins re
The Also worth noting: The server-side JS codebase in this repo provides a CLI helper utility for testing emails, provided by |
Ticket #3911 and #3909
Description
This PR ensures that:
Screenshots / Demo Video
Testing
Automated and Unit Tests
Manual tests for Reviewer
Checklist