Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to build ROS1 packages to save time #2434

Open
MishkaMN opened this issue Aug 28, 2024 · 0 comments
Open

Do not attempt to build ROS1 packages to save time #2434

MishkaMN opened this issue Aug 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@MishkaMN
Copy link
Contributor

Summary

Currently I am removing some ROS1 code from carma-utils and carma-platform.
Carma-platform itself has only carma_record and mock_drivers as ROS1.
However, due to how CMake and build script is written, it is still taking some non-trivial time to parse through each packages to determine whether to build or not. This can be optimized by not trying to build it in the first place.

See below how each package is almost taking 4s on my local VM before determining it is ROS2 and should not be built.
It is not a huge optimiziation, but something we probably can easily do if ROS1 is here to stay for a while.
image

Reasoning for new functionality

No response

@MishkaMN MishkaMN added the enhancement New feature or request label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant