Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with TLS and Auth requirements not defaulting to True #25

Closed

Conversation

drewjj
Copy link
Collaborator

@drewjj drewjj commented Sep 11, 2024

PR Details

Description

This pull requests modifies the email sender to default the use of TLS and Auth to true instead of false. This ensures the CV Manager is defaulting to the most secure email methodologies and is backwards compatible to older deployments of the CV Manager.

The count emails have now been modified to not display unknown RSUs since it isn't desirable to have unknown RSUs displayed in count emails where there is an expected small subset of RSUs. This prevents situations leading to email recipients being confused by unknown RSUs that may not even be within their jurisdiction.

How Has This Been Tested?

This has been tested locally with unit tests and deployed in GCP GKE.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • All existing tests pass.

@drewjj drewjj closed this Sep 11, 2024
@drewjj drewjj deleted the Fix/update-emailer-defaults branch September 11, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant