Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual clippy run for dependabot PRs 🦖 #1027

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

ascjones
Copy link
Collaborator

Dependabot 🤖 PRs only have read permissions, so dependabot PRs auto merged to master fail with "Resource not accessible by integration".

This PR implements this workaround which runs clippy "manually" when the permissions are not present.

This is safer than just giving write permissions by default to GITHUB_TOKEN

@ascjones ascjones requested review from a team, cmichi, HCastano and SkymanOne as code owners March 15, 2023 14:44
@ascjones ascjones changed the title Manual clippy run for @dependabot PRs 🦖 Manual clippy run for dependabot PRs 🦖 Mar 15, 2023
@ascjones
Copy link
Collaborator Author

Ignore the dependabot-auto-merge failure. It must have been summoned since I mentioned said 'bot in the PR title

Copy link
Contributor

@SkymanOne SkymanOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🦖

@ascjones ascjones merged commit cb3ea3f into master Mar 15, 2023
@ascjones ascjones deleted the aj/ci-clippy-permissions branch March 15, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants