Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add diamond toolmsg #1414

Merged
merged 2 commits into from
Feb 21, 2025
Merged

add diamond toolmsg #1414

merged 2 commits into from
Feb 21, 2025

Conversation

bgruening
Copy link
Member

ping @SaimMomin12

Do you want to change the sentence, or anything else? Is this shift ready?

@SaimMomin12
Copy link
Contributor

ping @SaimMomin12

Do you want to change the sentence, or anything else? Is this shift ready?

The sentence looks good to me. Yes the shift is ready from our side.

sanjaysrikakulam
sanjaysrikakulam requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@sanjaysrikakulam sanjaysrikakulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the tool_id have to be a list inside the toolmsg_messages.

@sanjaysrikakulam
Copy link
Member

Pushed a commit fixing things.

@bgruening bgruening merged commit de9a0e3 into master Feb 21, 2025
2 checks passed
@bgruening bgruening deleted the diamond_toolmsg branch February 21, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaysrikakulam sanjaysrikakulam sanjaysrikakulam requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgruening @SaimMomin12 @sanjaysrikakulam