Avoid removal of virtual method calls from call graph when applying method overrides #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #83 .
We are currently moving in the other extreme, because there are other schemes that we might be able to remove safely.
Looking at my project, I see the following override relations:
(left is overwritten by right).
Without too much research, it looks like most of them should stay in the call graph even after expanding it.
The first one might be removable (see here, functionSet seems to be an intermediate representation).
@jurgenvinju also pointed out that we might want to look at individual virtual methods and filter out the ones that do not have an implementation.