Moved to the latest rascal and rascal-plugin release #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed those return type things last week on a local branch. So I'll merge that a.s.a.p. |
Better let the build fall while we have static errors
|
@jurgenvinju & @PaulKlint the code now typechecks, there are now 2 errors in the tests. |
…ter for an overloaded alternative and two different return types for two overloaded alternatives
|
@jurgenvinju this one is ready for merging I think. |
|
@jurgenvinju this one is ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jurgenvinju & @PaulKlint I think rascal-core is finding a few errors that might not be errors:
Variable(s) \join should be introduced on both sides of||operatorrascal#1956nothing()ofutil::Maybein a kwparam default is causing the following error:apart from that, for @jurgenvinju to pickup, there are quite some errors where the overloads have different return types. In this PR I fixed a few of the type errors that where easy to fix, but these I'll leave for you.