Reusable actions and update chrome(driver) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshots are still mangled as per #33, so this solves only 'reuse' of workflow steps. |
|
Artifacts step is needed, so this is the most re-usable as I can get it, I think. |
|
@jurgenvinju got on opinion on this? I know the screenshots are fixed by you, but this still has the benefit of updated chrome and of no github actions duplication |
|
I like simplifications like this. Thanks @JJWTimmer |
jurgenvinju
approved these changes
Dec 21, 2023
|
Pls merge when you are ready @JJWTimmer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest actions and make a reuable file for base actions