-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added optional storage of constructor names and datatype names while serializing to JSON. Wired this through the different webservers as well #1862
Conversation
…serializing to JSON. Wired this through the different webservers as well
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1862 +/- ##
========================================
Coverage 49% 49%
- Complexity 6315 6337 +22
========================================
Files 664 665 +1
Lines 59584 59687 +103
Branches 8640 8670 +30
========================================
+ Hits 29496 29624 +128
+ Misses 27877 27827 -50
- Partials 2211 2236 +25 ☔ View full report in Codecov by Sentry. |
…k as well to improve constructor and type selection accuracy
this requires some tests to be added. other than that it seems to do the job. |
@DavyLandman There is another later PR on JSON IO about embedded parsers/unparsers for string values in JSON. This one precedes that one so let's merge this one first. This current feature can be essential for applications/frameworks such as salix that need to unambiguously communicate syntax trees to and from the web clients. |
… and their deprecation is too
This adds
explicitConstructorNames
andexplicitDataType
as keyword parameters to the JSON readers and writers. An constructorfoo(bar(), what())
will be printed as such whenexplicitConstructorNames=true
:This facilitates mapping syntax trees to JSON.