Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary isEmpty check from isSameFile. #1899

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

leegbestand
Copy link
Contributor

Closes #1897

@jurgenvinju jurgenvinju self-requested a review December 14, 2023 14:57
Copy link
Member

@jurgenvinju jurgenvinju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @leegbestand

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c05758) 49% compared to head (a8d1d41) 49%.

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #1899   +/-   ##
=======================================
  Coverage       49%     49%           
- Complexity    6152    6165   +13     
=======================================
  Files          661     661           
  Lines        58697   58697           
  Branches      8546    8546           
=======================================
+ Hits         28936   28951   +15     
+ Misses       27570   27554   -16     
- Partials      2191    2192    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jurgenvinju jurgenvinju merged commit 954d148 into usethesource:main Dec 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary isEmpty check inside isSameFile
2 participants