-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepares the removal of the final annotation (Tree@\loc), including its definition and all of its uses. PR to be merged when rascal-core project is stable. #1974
base: main
Are you sure you want to change the base?
Conversation
… _only_ work for Eclipse. We can upgrade Eclipse to also use util::IDEServices and util::LanguageServer, or we can drop them as soon as we drop Eclipse
The
It has to run on the entire project to make sense as the refactoring is "dumb"; it does not follow name resolution links it just replaces all syntactical constructs in a consistent manner. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
========================================
- Coverage 49% 49% -1%
+ Complexity 6297 6244 -53
========================================
Files 664 665 +1
Lines 59558 59624 +66
Branches 8639 8645 +6
========================================
- Hits 29437 29294 -143
- Misses 27908 28140 +232
+ Partials 2213 2190 -23 ☔ View full report in Codecov by Sentry. |
This PR allows for some testing until we've decided it is a good time to merge; when rascal-core is stable.
lang::rascal::upgrade::UpgradeAnnotationsToKeywordParameters
report
from this module first to see what the relevance and impact would beThis change impacts all projects with code that uses
Tree.\@loc
; so that's a lot. It makes sense to document how to use the automated refactoring or to link this into a UI feature (lenses?) for easy-of-use.This branch does not remove the old feature yet for two reasons:
Tree@\loc
works against a definition ofTree(loc src=|unknown:///|)
! So everybody will have to runupdate(myProjectSourceFolder)
anyway.Commits: