Add bin folders of dependencies to the classpath when they're open in the workspace #2094
Conversation
| @@ -543,8 +543,10 @@ public static PathConfig fromSourceProjectRascalManifest(ISourceLocation manifes | |||
| switch (mode) { | |||
| case INTERPRETER: | |||
| srcsWriter.appendAll(childConfig.getSrcs()); | |||
| libsWriter.append(childConfig.getBin()); | |||
There was a problem hiding this comment.
It might be conceptually nicer (?) to:
- Generalize the
binfield fromISourceLocationtoList<ISourceLocation>(and rename the field tobins) - Add the
binlocations from the dependencies to that list
But, I expect this will touch a lot more places in the existing code, so I thought I'd go for the solution with the smallest footprint first...
There was a problem hiding this comment.
The bin folder must be in one place; this follows the target folder convention in other build systems like mvn. Also it is required to be unambiguous and unique, because this is what ends up being packaged into a runtime module like a jar or zip or doll.
There was a problem hiding this comment.
I think this does the trick! Surgical precision 👍
| case COMPILER: | ||
| // FIXME (?): Add something to `srcsWriter` here? | ||
| libsWriter.append(setTargetScheme(projectLoc)); | ||
| break; |
There was a problem hiding this comment.
Davy asked to be mindful of possible similar changes for COMPILER, so I added this FIXME provisionally. I'm not sure if the sources need to be explicitly added, or if this is already covered as part of the libs.
There was a problem hiding this comment.
No the compiler never uses libraries from source positions. That's the main difference between interpreter and compiler mode.
There was a problem hiding this comment.
That's the important feature of the Compiler to be able to work with binary dependencies. It's also important to keep a "single source of truth" , the exact bill of materials, for library dependencies: we never depend on both the source and the binary ofa library.
sungshik
deleted the
replace-lib-by-mvn-and-others-fix/target-folders-on-classpath
branch
|
Thank you for clarifying! Removed the FIXME and merged. |
Before this PR, when a REPL was created in a project, and when one of its dependencies (as declared in the POM) was open in the same workspace:
srcfolder of the dependency was loaded from the workspace;binfolder of the dependency wasn't loaded at all (neither from the workspace, nor from the local Maven repository).After this PR, the
binfolder is loaded from the workspace, too. This PR fixes the following issue (inrascal-language-servers):See the separate comments for additional clarification/questions.