Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the tuple syntax to a plus list again, with corresponding changes in calls to getters #2134

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

jurgenvinju
Copy link
Member

@jurgenvinju jurgenvinju commented Jan 29, 2025

This should undo the cause for #2133 without fixing the underlying issue.

  • We need this revert because the current interpreter is unable to boot the next version of the type-checker.
  • Ignore any test functions that accept value as a parameter, since empty tuples can be generated which we can't
    write matching or expression code against. In particular the JSON tests must be made quiet until we fix Plus list variable not accepted in Star list position in concrete syntax #2133 for real.

@jurgenvinju jurgenvinju marked this pull request as ready for review January 29, 2025 13:04
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50%. Comparing base (14ecaa6) to head (61f2ff2).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/ast/Expression.java 62% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2134   +/-   ##
=======================================
- Coverage       50%     50%   -1%     
- Complexity    6243    6245    +2     
=======================================
  Files          673     673           
  Lines        58830   58844   +14     
  Branches      8599    8599           
=======================================
- Hits         29577   29539   -38     
- Misses       27020   27065   +45     
- Partials      2233    2240    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavyLandman DavyLandman merged commit 1bb6b4b into main Jan 29, 2025
7 checks passed
@jurgenvinju
Copy link
Member Author

Let's keep this branch around so we can revert the commits as soon as issue #2133 is truly fixed.

@DavyLandman
Copy link
Member

@jurgenvinju how about you open a draft PR with the revert?

@DavyLandman DavyLandman deleted the revert-empty-tuple-syntax branch March 10, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plus list variable not accepted in Star list position in concrete syntax
2 participants