Chore/update to latest rascal #8
Conversation
|
This is a new rascal feature only implemented by the static checker and not by the interpreter: Names starting with an underscore can not be used, and are not complained about when they are not used. It's a new effective way to document the parameter position that you match with _ to ignore it. |
|
Let's set errorsAsWarnings to false to see how for we can get in solving the issues here. We're getting very close. Lots of improvement since 0.7.8 of rascal-core |
Let's see how many errors we can solve.
For the parameters this makes sense (due to overloading etc). But in this case it's both an error to name a function |
| @@ -288,7 +286,7 @@ Attr onSubmit(Msg msg) = event("submit", succeed(msg)); | |||
| Attr onBlur(Msg msg) = event("blur", succeed(msg)); | |||
| Attr onFocus(Msg msg) = event("focus", succeed(msg)); | |||
|
|
|||
| Attr onCheck(Msg(bool) f) = event("change", targetChecked(f)); | |||
| Attr onCheck(Msg(bool) f) = event("check", targetChecked(f)); | |||
There was a problem hiding this comment.
@tvdstorm I've fixed a c&p error (the onCheck function was defined twice), I hope I generated the right events.
|
@tvdstorm / @jurgenvinju this one is ready for merging I think. |
|
ok, offline I got approval by @jurgenvinju |
@jurgenvinju / @PaulKlint rascal-core is complaining about functions that start with an underscore, is there a reason for this?
Since
<errorsAsWarnings>istruewe can skip fixing it, but can we maybe explain in the error message why it's an error?