fixed bottleneck in tuple.equals

usethesource · Jan 8, 2024 · c6d5900 · c6d5900
1 parent 22f2294
commit c6d5900
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/io/usethesource/vallang/impl/persistent/Tuple.java b/src/main/java/io/usethesource/vallang/impl/persistent/Tuple.java
@@ -174,10 +174,11 @@ public boolean equals(@Nullable Object o) {
 		if (o.getClass() == getClass()) {
 			Tuple otherTuple = (Tuple) o;
 
-			if (getType() != otherTuple.getType()) {
-			    return false;
+			// checking for the type will dynamically allocate memory
+			// because tuple types are computed lazily.
+			// so we skip this "fast failure" check
+			// if (getType() != otherTuple.getType()) { return false; }
 
-			}
 
 			IValue[] otherElements = otherTuple.elements;
 			int nrOfElements = elements.length;