added forceDepthFirst flag to closure and closureStar for testing purposes

[jurgenvinju]

This does not terminate while running the tests yet. Probably an issue with the IBool value generator?

[DavyLandman]

Do we need to break our public contract for this? How about still having the regular function in here?

[jurgenvinju]

Right, yes we should have a default version.

[DavyLandman]

how about we give it an enum? or a way to say: auto vs DFS/BFS? so a user can say: hey, this is BFS, so let's go for that. Since even for big collections, there are graphs where BFS is better.

[jurgenvinju]

This is only for testing purposes. We can never give this to the rascal user anyway. And to be honest, there are dozens of algorithms we still have to try. It's quite possible that the distinction between DFS and bfs becomes a lot more vague.

[github-actions]

Test Results

     55 files   -      41       55 suites   - 41   3m 3s ⏱️ - 4m 12s
177 875 tests  -  64 414  177 874 ✅  -  64 414  1 💤 ±0  0 ❌ ±0 
368 540 runs   - 358 414  368 538 ✅  - 358 413  2 💤  - 1  0 ❌ ±0 

Results for commit 849c655. ± Comparison against base commit 073dbdd.

This pull request removes 64614 and adds 200 tests. Note that renamed tests count towards both.

io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory)[1]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory)[2]
io.usethesource.vallang.specification.IRelationTests ‑ broadClosure(IValueFactory)[1]
io.usethesource.vallang.specification.IRelationTests ‑ broadClosure(IValueFactory)[2]
io.usethesource.vallang.specification.IRelationTests ‑ carrierForTriples(ISet)[100]
io.usethesource.vallang.specification.IRelationTests ‑ carrierForTriples(ISet)[101]
io.usethesource.vallang.specification.IRelationTests ‑ carrierForTriples(ISet)[102]
io.usethesource.vallang.specification.IRelationTests ‑ carrierForTriples(ISet)[103]
io.usethesource.vallang.specification.IRelationTests ‑ carrierForTriples(ISet)[104]
io.usethesource.vallang.specification.IRelationTests ‑ carrierForTriples(ISet)[105]
…

io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[100]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[101]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[102]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[103]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[104]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[105]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[106]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[107]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[108]
io.usethesource.vallang.basic.RelationSmokeTest ‑ testClosure(IValueFactory, IBool)[109]
…