Avoided self loop in case there is already an self edge to begin with #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 96 files 96 suites 6m 11s ⏱️ Results for commit 9aa70d3. ♻️ This comment has been updated with latest results. |
jurgenvinju
reviewed
Jan 15, 2024
src/main/java/io/usethesource/vallang/impl/persistent/PersistentHashIndexedBinaryRelation.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small perf fix for the case that a graph contains a lot of self refering edges to begin with. This saves of a whole lot of steps in that case.
Also realized the adding to
donecan be placed after it's done, to better align with where you would expect this to happen.