Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize whitespace #271

Merged
merged 8 commits into from
Sep 7, 2024
Merged

Normalize whitespace #271

merged 8 commits into from
Sep 7, 2024

Conversation

DavyLandman
Copy link
Member

This PR:

  • normalizes whitespaces (30% of the lines were tabs, now it's all 4 spaces)
  • removed trailing whitespace
  • normalize indentation (it was mostly 4 spaces, but some parts were 2 spaces or tabs/space mixed)
  • add a check around common java idioms
  • verify at PR time nothing is introduced that we don't want (but be very conservative of the rules we user)

Copy link

github-actions bot commented Sep 6, 2024

Test Results

     99 files  ±0       99 suites  ±0   5m 48s ⏱️ +6s
242 302 tests ±0  242 301 ✅ ±0  1 💤 ±0  0 ❌ ±0 
726 993 runs  ±0  726 990 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit decd011. ± Comparison against base commit b4a6545.

@jurgenvinju
Copy link
Member

This is great. Very annoying that these things keep creeping in. I blame the constant hidden evolution of editor settings. Now that's at least stopped. And fixed. Thanks!

@jurgenvinju jurgenvinju merged commit cc14797 into main Sep 7, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants