Skip to content

Commit

Permalink
Removed RuboCop TODO
Browse files Browse the repository at this point in the history
These are mostly fixed now. There's still more work to do but this at least removes the need for the TODO list.
  • Loading branch information
bkuhlmann committed Feb 20, 2025
1 parent 2bfa4a8 commit 326cfdb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 23 deletions.
5 changes: 4 additions & 1 deletion .config/rubocop/config.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
inherit_gem:
caliber: config/all.yml

inherit_from: issues.yml
Naming/VariableNumber:
Exclude:
- app.rb
- services/screen_fetcher.rb
21 changes: 0 additions & 21 deletions .config/rubocop/issues.yml

This file was deleted.

3 changes: 2 additions & 1 deletion app.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,14 @@ def create_forme model, _is_edit, attrs = {}, options = {}
set :force_ssl, false
end

# DEVICE MANAGEMENT
# rubocop:todo Style/TopLevelMethodDefinition
def devices_form device
create_forme device,
device.persisted?,
{autocomplete: "off", action: "#{ENV.fetch "BASE_URL"}/devices"},
{namespace: "device"}
end
# rubocop:enable Style/TopLevelMethodDefinition

get "/devices/?" do
@devices = Device.all
Expand Down

0 comments on commit 326cfdb

Please sign in to comment.