Fixed RSpec UI/API setup and testing #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary to ensure the headless Chromium driver is available for testing purposes.
Necessary to improve our test suite since not having Cabybara's DSL makes things too cumbersome. By adding these gems we'll be able to clean up our Sinatra (web) specific specs. Documentation: * link:https://github.com/teamcapybara/capybara[Capybara] * link:https://cuprite.rubycdp.com[Cuprite] * link:https://rubygems.org/gems/launchy[Launchy] We no longer need to require Ferrum because Cuprite is built upon it.
Necessary to parsing API repsonses. This in a `sinatra` folder to ensure there is a distinction between pure Ruby and Sinatra contexts.
Necessary to have a helper for pure Ruby code (i.e. `spec_helper.rb`) and another helper for for the web framework (i.e. `sinatra_helper.rb`). This mostly pulled from link:https://alchemists.io/projects/hanamismith[Hanamismith] but adapted for Sinatra. This properly wires up Capybara so we can write spects that test the UI without having to spend so much time digging into the HTML DOM. 🎉
Necessary to simplify writing Web UI specs. Duplicate specs were removed because they are identical to what's in the setup spec.
Necessary to clean up the specs further by clearly defining the subject and leveraging the API shared context for improved clarity and reduced duplication.
Necessary to clarify that this is a pure Ruby shared context (not to be confused with Sinatra) and is meant to be used by the `spec_helper.rb` only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Necessary to make writing UI and/or API specs much easier by using Capybara for the former and Rack for the the latter. This has the added benefit of bringing clarity to the specs so you can use
visitor simple Rack HTTP verb methods. Chromium is wired up for headless testing to make all of this simple to use.Details