Crowdin stuff #37
Merged
Crowdin stuff #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure if this is a mistake instead of using the Crowdin CLI but we'll see
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
add mod
KTrain5169
removed
enhancement
github-actions
bot
added
add mod
KTrain5169
removed
enhancement
|
sigh why is PR workflow refusing to work properly |
github-actions
bot
added
add mod
nice... |
|
I've labeled your PR, assigned you and requested/un-requested reviews from the relevant people automatically. If you think I did it wrong, please comment below so one of our maintainers can double-check. Thanks! |
|
yes, you did it wrong they already reviewed it |
github-actions
bot
added
the
Merge conflict identified
|
This pull request has conflicts with the base branch, which is main. Please resolve them. |
|
uh... I kinda can't? |
|
Resolved conflicts! |
github-actions
bot
removed
the
Merge conflict identified
|
|
|
Now we just need to check with @KTrain5169 that all is in order and we can merge |
worldwidepixel
approved these changes
Aug 28, 2024
|
I need to double-check some things regarding the workflow and the necessary files (I can't remember if the crowdin.yml is supposed to be placed in the branch root or in .github and I can't check right now)
So yeah don't merge it yet I'll merge it myself in a couple of hours
|
KTrain5169
added a commit
that referenced
this pull request
Aug 29, 2024
This reverts commit 40449f7.
Merged
KTrain5169
added a commit
that referenced
this pull request
Aug 29, 2024
This reverts commit 40449f7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Category
Describe changes
Added GitHub Action that automatically pulls from Crowdin and updates strings. Also adds a translation progress badge to README because why not?
Why did you do this?
Makes it easier to integrate with Crowdin. The current solution being used at StopMalwareContent (owned by Nitrrine) is apparently not the best? And using the CLI via
pnpmmay expose secrets.BREAKING CHANGES
What issues (if any) would this resolve?
Resolves #36
Extra notes?
This PR should not be merged until all secrets are set. The secrets that need to be set are the following:
contents: writeGITHUB_TOKEN should work, but if for some reason it doesn't (I can't test rn due to some factors namely requiring Crowdin strings to be not updated I think?) then a collaborator/owner of the repo needs to create a GitHub PAT with the scope selected.Checklist
Vercel will begin deploying to the Preview environment shortly after submitting this pull request. You may click on the "Visit Preview" link below to see a preview of what your changes look like.
If you updated only part of the repository such that it would not modify the website at all, you do not need to see the Vercel deployment.
You may also use the StackBlitz Codeflow button to quickview the PR in the browser and make changes at the same time if necessary.