Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid2GMT: upgrade supported GMT version and change to bash script? #15

Open
sean0921 opened this issue Jan 16, 2022 · 1 comment
Open

Comments

@sean0921
Copy link
Contributor

sean0921 commented Jan 16, 2022

I think both changes can improve the maintainability of this project:

  • change GMT script format to let it compatible with >= 5 can let more people access this tool without install GMT 4.x manually
  • change script type from csh to bash and use more POSIX and bash feature (e.g. set -x) for easier tracing and debugging GMT scripts.

I already make some patch for a bit older beta version(1, 2), if this kind of change is acceptable, I will also make PR for this issue.

@alomax
Copy link
Collaborator

alomax commented Jan 17, 2022

I agree. Especially for csh to bash!

But for GMT, this means changing C code in Grid2GMT.c that generates the GMT scripts - not a minor task to modify, debug and verify. I have not made these changes because:

  • I rarely use Grid2GMT, I use SeismicityViewer for visualizing NLLoc locations. I mainly use Grid2GMT for verifying velocity and travel-time grids.
  • I did change GMT4 to GMT5 for another (real-time) project, but had to revert to GMT4 because GMT5 was much too slow! GMT 5 much slower than GMT 4? GenericMappingTools/gmt#587 (comment)
  • There is now a GMT6, which may or may not be backwards compatible with GMT5. In general, I do not see how low- or no-budget developers of research software (sometimes well established, mission-critical!) are supposed to find the time and funding to keep up with quite frequent (as little as 2 years!), non-backwards compatible changes to widely used codes, libraries and languages. So I kind of give up! And so much software must be breaking - does not bode well for the dream of replicability of scientific results! I think maintaining backwards compatibility should be a requirement for scientific software development and funding.

However, it would be quite useful if you or others have time, need and interest in upgrading the codes, I am certainly available to assist with this process.

Thanks,
Anthony

@sean0921 sean0921 changed the title upgrade supported GMT version and change to bash script? Grid2GMT: upgrade supported GMT version and change to bash script? Aug 23, 2022
@alomax alomax mentioned this issue Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants