Grid2GMT: upgrade supported GMT version and change to bash script #30
Conversation
|
Hi @sean0921 Also feel free to add your credit and contact information in the comments at the top of the file, if you wish, I hope so! Thanks, |
CompilationGMT4mkdir build
CFLAGS='-DGMT_VER_4' cmake -Bbuild .
make -C build
#copy binary under bin/ to your path
rm -rvf build/GMT5 or 6mkdir build
cmake -Bbuild .
make -C build
#copy binary under bin/ to your path
rm -rvf build/Test the AppI have tested it with my own data before, and I will post the result pictures tested with |
|
Hi For an existing NLL model grid, I tried running the upgraded Grid2GMT with I then tried with This runs fine with the old Grid2GMT using GMT4... Here are the required files to run this test: https://www.dropbox.com/sh/clslnyynw2chtg9/AABYIKJlTwWNJhrdiHl1EAxaa?dl=0 Any thoughts? Thanks |
|
Thanks for your feedback and helpful information! I'm trying to reproduce this problem, if there is any idea and related fix about this, I will post here. Thanks |
|
After comparing two version of generated scripts. I found that I've ignored I will push related commits in this PR after this problem is fixed. |
|
The introduction of the |
- cleanup unused code block due to GMT_VER_3_3_4 is always defined - remove GMT_VER_3_3_4 defined macro - add GMT_VER_5 macro for enable 5 and later verion capability
sean0921
force-pushed
the
sean/upgradegmt
branch
from
d0a3fc9 to
ba03006
Compare
enable GMT_VER_5 can generate gmt >=5 compatible script If we use default build procedure, and not define anything it will still generate script that uses gmt 4.x
sean0921
force-pushed
the
sean/upgradegmt
branch
from
ba03006 to
c453a7e
Compare
CompilationGMT 4Use original build procedure GMT 5 or 6edit CMakeLists.txt to uncomment following line: then: Test the AppI have tested it with:
ResultDataset [1]
Dataset [2]Google Drive link: https://drive.google.com/drive/folders/1OvMsQIQfOKf_LEG1KQDwMjJkq_bNIitQ?usp=sharing |
sean0921
force-pushed
the
sean/upgradegmt
branch
from
2481a60 to
678b448
Compare
|
I have fixed this problem and simply wrote up the way to test new code in PR and Regards, |
|
Hi Sean, |
|
Hi Sean Sorry for the big delay. I am finally using Grid2GMT and have time to experiment with your modifications. Running with GMT6 seems to work fine, but gives one error message: But GMT5 fails: So basically I can and will use GMT6. If we can get GMT5 running, all the better. Thanks so much again! A great improvement for all users of NonLinLoc. Anthony |
|
It seems that Maybe I will temporary remove this option in order to support both GMT version, if the generated layout still seems to be fine. |
sean0921
force-pushed
the
sean/upgradegmt
branch
from
5ff4139 to
163fd30
Compare
|
Hi Sean I have merged and tested all your changes remotely and pushed to the main branch here. Anthony |
Although this program has been almost replaced by SeismicityViewer for visualizing NLLoc locations, but when we want to customize to visualization of results generated by this program, Grid2GMT are still valuable for reference. So I still want to make PR for this program.
This PR mainly make these changes( #15 ):
GMT_VER_4macro before compiling.cshtobashand use more POSIX and bash feature (e.g.set -x) for easier tracing and debugging GMT scripts.