Review FTE SQL

[andreabringhurst]

• Read through all the SQL code.
• Identify the purpose and functionality of each query.
• Note any immediate issues or areas for improvement.
• Create consistency in the queries in both structure and output.
• Add comments explaining the purpose of each query.
• Document any assumptions or dependencies.

[andreabringhurst]

I have reviewed the fte queries.
fte_grad_cred_hour_census - Is correct, but too narrow
fte_off_dscir - is correct, do we still need it?
fte_off_edify - is incorrect, it is using student level instead of course level when calculating the fte; it is also using registered_credits, and fte_grad_cred_hour_census, fte_ug_cred_hour_census, and fte_ug_cred_hour_eot are using attempted_credits
fte_off_rept - is incorrect, is is using student level instead of course level when calculating the fte
fte_ug_cred_hour_census - is correct, but too narrow
fte_ug_cred_hour_eot - is correct, but too narrow

[andreabringhurst]

After some discussion in code review yesterday, I added issues to address my concerns about the fte queries, #15 , #16 , #17 , #18 #19 , #20 , #21 .

[andreabringhurst]

@MattNickodemus after discussing some of the FTE stuff in code review yesterday, I would like to move forward with adding 3 new queries to utDataStoR - fte_total_census (#15), fte_total_eot (#16), and fte_total_current (#17 ). I think there are other issues we need to discuss before I do more, but those are the 3 that I would like to start with and are pretty straight forward. They provide fte by undergraduate, graduate and total for each term.

[andreabringhurst]

I just added issue #23 to this issue.

[andreabringhurst]

The FTE sql has been reviewed. I'm going to close it because I have a pull request #22 .