Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v6.0.0 #303

Merged
merged 1,175 commits into from
Apr 7, 2023
Merged

Update v6.0.0 #303

merged 1,175 commits into from
Apr 7, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Jan 31, 2023

Overview

Update v6.0.0

Issue

NA

Details

The following PRs are integrated into this PR

Validation results

See CI

Scope of influence

NA

Supplement

NA

Note

NA

@200km 200km added priority::medium priority medium major update incompatible API changes labels Jan 31, 2023
@200km 200km added this to the Major update for v6.0.0 milestone Jan 31, 2023
@200km 200km requested review from sksat and seki-hiro January 31, 2023 09:24
@200km 200km self-assigned this Jan 31, 2023
@200km
Copy link
Member Author

200km commented Feb 16, 2023

あ、ミスってこのブランチに直接pushしてしまった。

@200km
Copy link
Member Author

200km commented Feb 16, 2023

@suzuki-toshihir0 slackで議論したやつですが、b2c68fb0f18abfで対応したので一応確認してもらい、変なところあったら教えて下さい。

@suzuki-toshihir0
Copy link
Member

変更の中身確認しました.問題ありません.

@200km 200km added the automation::comment-graph comment simulation result graph on pull request label Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

position.png

position

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

position.png

position

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

position.png

position

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

position.png

position

@200km 200km changed the title WIP: Update v6.0.0 Update v6.0.0 Apr 5, 2023
@200km
Copy link
Member Author

200km commented Apr 5, 2023

@suzuki-toshihir0 @seki-hiro @sksat I removed WIP. Please start review of this PR.

Copy link
Member

@suzuki-toshihir0 suzuki-toshihir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffが非常に多いので,レビューの進め方は少し考えたいかもです.ほとんどのコードはすでに一度レビューが済んでいるのでだいたい良さそうであればapproveしてしまってよいのか,当時のレビュー抜けを拾うためにある程度丁寧に見る感じでいくべきか,想定あればお教えください.

CMakeLists.txt Outdated Show resolved Hide resolved
@200km
Copy link
Member Author

200km commented Apr 6, 2023

レビューの進め方

基本は別PRでレビューしてくれているので、細かくみていく必要はないと思います。
CIが通っていますが、もし気になるなら手元で動かしてもらって動くか見てもらうくらいですかね。

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

position.png

position

@suzuki-toshihir0
Copy link
Member

わかりました.他のコードもまとめてざっと確認したしたが,大丈夫そうに思います.
動作確認についてはCI通っているのでよいかなと思います.

@200km
Copy link
Member Author

200km commented Apr 7, 2023

マージします。

@200km 200km merged commit 5e39b08 into develop Apr 7, 2023
@200km 200km deleted the feature/major-update-v6.0.0 branch April 7, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation::comment-graph comment simulation result graph on pull request major update incompatible API changes priority::medium priority medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants