Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll top #46

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Scroll top #46

wants to merge 3 commits into from

Conversation

mohtasheem135
Copy link
Contributor

@mohtasheem135 mohtasheem135 commented Oct 15, 2024

Description

Added Scroll-to-top button

Fixes #32

Type of Change

  • Bug fix
  • New feature
  • Test update
  • Refactor
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have made corresponding changes to the documentation (README, CONTRIBUTING, etc).
  • I added a new Library/Dependency and have updated the README.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings or errors.
  • New and existing unit tests pass locally with my changes.

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for color-conjure ready!

Name Link
🔨 Latest commit 109adf2
🔍 Latest deploy log https://app.netlify.com/sites/color-conjure/deploys/671b95596dc9080008772b9b
😎 Deploy Preview https://deploy-preview-46--color-conjure.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -167,6 +196,15 @@ const Home = () => {
} // Callback when colors are generated
/>
))}
{isVisible && (
<button
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a component in Shared, you can use that

@@ -75,7 +76,7 @@ const Home = () => {
[id]: colorData,
}));
};

const baseColor = Object.values(generatedColors)[0]?.baseColor;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a code comment explaining what is this for

@@ -120,6 +121,34 @@ const Home = () => {
() => toast.error("Failed to copy colors to clipboard."),
);
};

const [isVisible, setIsVisible] = useState(false);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move this useState below line 22

Copy link
Owner

@utk09-NCL utk09-NCL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments

@mohtasheem135
Copy link
Contributor Author

Please resolve the comments

Bro in India it's 1:20am i have to sleep now... I have to wake up early tomorrow...

I'll fix these and submit the PR first thing in the morning.

@utk09-NCL
Copy link
Owner

Yeah sure, whenever it suits 😅 I leave comments so that I can / you can look at them later

@mohtasheem135
Copy link
Contributor Author

Yeah sure, whenever it suits 😅 I leave comments so that I can / you can look at them later

Cool 😅

@utk09-NCL
Copy link
Owner

Any updates on this @mohtasheem135 ?

@mohtasheem135
Copy link
Contributor Author

Sorry bro actually I was not well... That's why I was unable to share the PR.

I will give the the PR by today.

Again sorry for the delay.

@mohtasheem135
Copy link
Contributor Author

check now bro...

Again sorry for being so late

@utk09-NCL
Copy link
Owner

The project has been updated to use Typescript, please pull the latest main and create a new branch with your changes (if that's easier). Thank you for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: 18 - Page scroll to top button
2 participants