-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll top #46
base: main
Are you sure you want to change the base?
Scroll top #46
Conversation
✅ Deploy Preview for color-conjure ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/pages/Home.jsx
Outdated
@@ -167,6 +196,15 @@ const Home = () => { | |||
} // Callback when colors are generated | |||
/> | |||
))} | |||
{isVisible && ( | |||
<button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a component in Shared, you can use that
@@ -75,7 +76,7 @@ const Home = () => { | |||
[id]: colorData, | |||
})); | |||
}; | |||
|
|||
const baseColor = Object.values(generatedColors)[0]?.baseColor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a code comment explaining what is this for
src/pages/Home.jsx
Outdated
@@ -120,6 +121,34 @@ const Home = () => { | |||
() => toast.error("Failed to copy colors to clipboard."), | |||
); | |||
}; | |||
|
|||
const [isVisible, setIsVisible] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can move this useState
below line 22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the comments
Bro in India it's 1:20am i have to sleep now... I have to wake up early tomorrow... I'll fix these and submit the PR first thing in the morning. |
Yeah sure, whenever it suits 😅 I leave comments so that I can / you can look at them later |
Cool 😅 |
Any updates on this @mohtasheem135 ? |
Sorry bro actually I was not well... That's why I was unable to share the PR. I will give the the PR by today. Again sorry for the delay. |
check now bro... Again sorry for being so late |
The project has been updated to use Typescript, please pull the latest |
Description
Added Scroll-to-top button
Fixes #32
Type of Change
Checklist