Master merge preparations #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should resolve #195 before doing a release. This could be fixed after merge, but I think we should have the 3 desktop platforms before release of beta. |
|
@piiertho I agree. But merge != beta release. But at least testing can begin. |
|
@CedNaru , @piiertho @raniejade I think #169 needs to be fixed before we can merge. One cannot really test anything if this bug still occurs. For example I'm not able to set a texture on a sprite through code. Which is pretty severe. |
chippmann
force-pushed
the
feature/master-merge-preparations
branch
2 times, most recently
from
e2fc7c2
to
12ee4c6
Compare
chippmann
force-pushed
the
feature/master-merge-preparations
branch
from
12ee4c6
to
9b62844
Compare
|
Sorry made a rebase mistake which automatically closed this PR as there no more changes. Reopened it. |
chippmann
force-pushed
the
feature/master-merge-preparations
branch
from
b6a3d51
to
20b42de
Compare
|
Now included in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is intended to be used by every maintainer to do preparations for the merge of
master-mergeintomaster:Current ToDo List:
Variant.wrapusage for signal connection #189Variant.wrapcalls for registered properties and functions #186Set up linting with CodeStyle checksWill be implemented laterPlease add more if you see something that needs to be done before merging can happen.