Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ls: use try_get_matches_from instead of get_matches_from #5446

Merged
merged 2 commits into from
Oct 25, 2023
Merged

ls: use try_get_matches_from instead of get_matches_from #5446

merged 2 commits into from
Oct 25, 2023

Conversation

cakebaker
Copy link
Contributor

This PR replaces get_matches_from with try_get_matches_from to adapt clap's exit code. It makes https://github.com/coreutils/coreutils/blob/master/tests/ls/classify.sh pass and replaces #5437

@cakebaker
ls: use try_get_matches_from instead of
d7b7dfe 
get_matches_from to replace clap's exit code
@cakebaker cakebaker mentioned this pull request Oct 24, 2023
Closed
tertsdiepraam
tertsdiepraam approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sure I got all of these at some point, but apparently not 😄

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/classify is no longer failing!
GNU test failed: tests/ls/zero-option. tests/ls/zero-option is passing on 'main'. Maybe you have to rebase?

@cakebaker
Copy link
Contributor Author

In the latest push I added a fix to make tests/ls/zero-option pass again.

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/classify is no longer failing!

@tertsdiepraam tertsdiepraam merged commit 96d0830 into uutils:main Oct 25, 2023
@cakebaker cakebaker deleted the ls_try_get_matches_from branch October 25, 2023 09:35
@chenrui333 chenrui333 mentioned this pull request Nov 14, 2023
Merged
@moonfruit moonfruit mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @tertsdiepraam