du: implement files0-from #5721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
du-from-file
branch
from
8e5e867 to
de85d89
Compare
|
GNU testsuite comparison: |
|
Fails on Windows :| |
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 26, 2023
cakebaker
reviewed
Dec 26, 2023
cakebaker
reviewed
Dec 26, 2023
cakebaker
reviewed
Dec 26, 2023
Comment on lines
+609
to
+617
| Err(e) if e.kind() == std::io::ErrorKind::NotFound => { | ||
| return Err(std::io::Error::new( | ||
| std::io::ErrorKind::Other, | ||
| format!( | ||
| "cannot open '{}' for reading: No such file or directory", | ||
| file_name | ||
| ), | ||
| )) | ||
| } |
There was a problem hiding this comment.
This case is not covered by a test.
cakebaker
reviewed
Dec 26, 2023
cakebaker
reviewed
Dec 26, 2023
|
GNU testsuite comparison: |
Should make tests/du/files0-from-dir pass
Co-authored-by: Daniel Hofstetter <[email protected]>
Co-authored-by: Daniel Hofstetter <[email protected]>
sylvestre
force-pushed
the
du-from-file
branch
from
6efa1f9 to
13e8c32
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make tests/du/files0-from-dir pass