Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor code quality improvements #7177

Merged
merged 6 commits into from
Jan 23, 2025
Merged

minor code quality improvements #7177

merged 6 commits into from
Jan 23, 2025
+106 −169

Conversation

danieleades
Copy link
Contributor

No description provided.

@danieleades danieleades force-pushed the code-quality branch 3 times, most recently from bc95131 to 5ff8cce Compare January 20, 2025 07:49
@sylvestre
Copy link
Contributor

looks cool :)
is it from a clippy rule?

@danieleades
Copy link
Contributor Author

looks cool :) is it from a clippy rule?

there's a mixture, but a lot of these are from clippy::manual_let_else

@danieleades danieleades force-pushed the code-quality branch 2 times, most recently from 4972fbe to 2f506c4 Compare January 20, 2025 07:54
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/usage_vs_getopt. tests/misc/usage_vs_getopt is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/misc/stdbuf is no longer failing!

@danieleades danieleades marked this pull request as ready for review January 20, 2025 08:32
@sylvestre
Copy link
Contributor

Could you please merge all patches into one and explain that it is identified by clippy and add the 'name of the rule?

Thanks

@danieleades
Copy link
Contributor Author

Could you please merge all patches into one and explain that it is identified by clippy and add the 'name of the rule?

Thanks

i think you can do this using the 'squash merge' pull request feature, no?

@sylvestre
Copy link
Contributor

yes but I think you could write a proper commit message :)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/usage_vs_getopt is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/usage_vs_getopt is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 5d6a04a into uutils:main Jan 23, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieleades @sylvestre