[WIP] Velocity Based Cartesian Controller for Arm #182
Conversation
uwrt_arm_cartesian_controller/include/uwrt_arm_cartesian_controller/visibility_control.hpp
Outdated
Show resolved
Hide resolved
uwrt_arm_cartesian_controller/include/uwrt_arm_cartesian_controller/visibility_control.hpp
Outdated
Show resolved
Hide resolved
| ret.twist.angular.y = 0; | ||
| ret.twist.angular.z = 0; | ||
| ret.header.stamp = rclcpp::Time::now(); | ||
| // younes todo whats the name of the arm's base frame ret.header.frame_id = "foo"; |
There was a problem hiding this comment.
if im reading the xacro right the name of the arms base frame is called base link. wanted to confirm that this is right bc that name is typically reserved for a robots mobile base (ie the chassis link)
There was a problem hiding this comment.
it is rn. it should be changed. @meshvaD
There was a problem hiding this comment.
ill use the current name for now. @meshvaD can u pls lmk when u merge the change into master?
There was a problem hiding this comment.
Why do you actually need to hard code link names? They could be loaded ad parameters (ex. End effector link and arm base link)
uwrt_arm_cartesian_controller/src/uwrt_arm_cartesian_controller.cpp
Outdated
Show resolved
Hide resolved
| ROS_INFO_STREAM("***Listing HW Interfaces: ***"); | ||
| // Get joint handles for all of the joints in the chain | ||
| /*for (std::vector<KDL::Segment>::const_iterator it = kdl_chain_.segments.begin(); it != kdl_chain_.segments.end(); ++it) | ||
| { younes todo wut is this? wut is joing handles wut is command_interfaces |
There was a problem hiding this comment.
ros control stuff. joint handles = handles for the joints(it doubles as the name of the joint). command interfaces is the interfaces that the arm supports. in thjs case, u should validate that the interfaces are all vel interfaces or else throw an error
uwrt_arm_cartesian_controller/src/uwrt_arm_cartesian_controller.cpp
Outdated
Show resolved
Hide resolved
uwrt_arm_cartesian_controller/src/uwrt_arm_cartesian_controller.cpp
Outdated
Show resolved
Hide resolved
younesr1
force-pushed
the
user/yreda/181/write-cartesian-controller
branch
from
959a9db
to
7a320ff
Compare
still very much a wip. would still appreciate any feedback though