-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zed2 wrapper as a submodule #233
base: master
Are you sure you want to change the base?
Conversation
Does this have to be a submodule rather than a normal package we clone along with the others, such as |
Nope, ticket said submodule so I assumed you meant actual submodule. Changed it to just an upstream dependency - not sure if I need to add anything else. Lmk @keyonjerome |
Thanks -- yeah the submodule part was just me not thinking. Definitely works better as an upstream dependency. Feel free to merge this into your branch and deal with the failing lint checks there. |
zed2_ros_wrapper: | ||
type: git | ||
url: https://github.com/stereolabs/zed-ros2-wrapper.git | ||
version: master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like specifying a specific commit here instead of master
such that our repo doesn't randomly break in the case that they change something on the stereolabs/zed-ros2-wrapper
side.
Added the zed-ros2-wrapper as a submodule in our repo.
Also updated the readme to include recursive subclone (ie clone the submodule automatically).
Im not sure if I need to add any other dependencies/checks here or if I need to add any of the packages to ci.yaml (I assume I dont but just checking)