Change system_update.py and uyuni-tools/group_system_update.py for Pole #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbrookhuis
commented
Aug 24, 2022
mbrookhuis
commented
- Change system_update.py and uyuni-tools/group_system_update.py for Pole Emploi
- This is a fix for Issue SP Migration for openSUSE #12
juliogonzalez
requested changes
Sep 26, 2022
rjmateus
reviewed
Sep 26, 2022
|
@mbrookhuis looks strange, but |
|
removed .idea. |
Please fix the permissions as requested by Viktor, as the PR is making executable (755) a lot files that don't need to be executable (yaml, txt, md...) My guess is that only the .py script you are changing should be executable, and not sure about a couple of other .py scripts and the file |
juliogonzalez
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
LGTM, as you can see I sent the fixes for the permissions on my own, so @mbrookhuis please review in case I broke something :-D
rjmateus
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.