Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Check: disconnected solution #9322

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

Conversation

ycedres
Copy link
Contributor

@ycedres ycedres commented Oct 4, 2024

What does this PR change?

Initial implementation of the Disconnected solution. No access to an Uyuni server or existing monitoring stack, only access to a supportconfig.

Summary of changes:

  • Introduce new container packages to build images for the different health check components. Using BCI images.
  • Introduce new mgr-health-check package to build CLI.
  • Provide Grafana dashboard to show metrics and logs coming from a "supportconfig"
  • Implement alerts based metrics.

Some screenshots:

image
image

See: https://github.com/uyuni-project/uyuni-rfc/blob/master/accepted/00101-health-check-tool.md

Documentation

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: no tests for health check

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24380

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Member

@agraul agraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few questions inline. I think we should enable the linter as soon as we can, it will be a bit of work to bring the code up to our standards (as expected for PoC code)

@m-czernek
Copy link
Contributor

Remaining tasks:

ycedres and others added 25 commits March 11, 2025 11:05
At this point the completion-checker script just processes .log files
and not compressed files as it seems that the information in the
positions.yaml file is not the number of bytes for the .tar.gz file but
instead, the number of lines in the logfile inside the .tar.gz. This
breaks the logic of the completion-checker so this is a partial solution
at this moment.
@meaksh meaksh force-pushed the health-check-skeleton branch from 4da2e76 to e316cba Compare March 11, 2025 11:48
@meaksh meaksh changed the title Uyuni Health Check Tool Disconnected Solution Health Check: disconnected solution Mar 11, 2025
@meaksh meaksh marked this pull request as ready for review March 11, 2025 13:04
@meaksh meaksh requested a review from a team as a code owner March 11, 2025 13:04
@meaksh meaksh requested review from meaksh and removed request for a team March 11, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants